Mark, On Fri, Dec 1, 2017 at 1:49 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote: >> On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen <erick.chen@xxxxxxxxxxxxxx> wrote: > >> I think that per Linus, and Thomas doc patches for SPDX ids this >> should be instead either: > >> > +// SPDX-License-Identifier: GPL-2.0 >> > + // Copyright (c) 2017 Spreadtrum Communications Inc. > >> or at least this with the id on the first and the // comment style > >> > +// SPDX-License-Identifier: GPL-2.0 > > Are you saying SPDX requires C++ style comments? That seems totally > broken. In can understand your point, but for reference please check Linus [1][2][3], Thomas[4] and Greg[5] comments on the topic. I am just a lowly messenger and even though I personally agree with Linus points and taste in this area, my weightless voice does not matter. CC: Linus, Greg and Thomas [1] https://lkml.org/lkml/2017/11/2/715 [2] https://lkml.org/lkml/2017/11/25/125 [3] https://lkml.org/lkml/2017/11/25/133 [4] https://lkml.org/lkml/2017/11/2/805 [5] https://lkml.org/lkml/2017/10/19/165 -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
