On Tue, Nov 28, 2017 at 9:44 PM, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > Hi Rob, > > > 2017-11-29 0:27 GMT+09:00 Rob Herring <robh@xxxxxxxxxx>: >> On Tue, Nov 28, 2017 at 04:49:45PM +0900, Masahiro Yamada wrote: >>> The driver has been in the tree for a while, but its binding document >>> is missing. Hence, here it is. >>> >>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> >>> --- >>> >>> .../pinctrl/socionext,uniphier-pinctrl.txt | 27 ++++++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 28 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.txt >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.txt >>> new file mode 100644 >>> index 0000000..8173b12 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.txt >>> @@ -0,0 +1,27 @@ >>> +UniPhier SoCs pin controller >>> + >>> +Required properties: >>> +- compatible: should be one of the following: >>> + "socionext,uniphier-ld4-pinctrl" - for LD4 SoC >>> + "socionext,uniphier-pro4-pinctrl" - for Pro4 SoC >>> + "socionext,uniphier-sld8-pinctrl" - for sLD8 SoC >>> + "socionext,uniphier-pro5-pinctrl" - for Pro5 SoC >>> + "socionext,uniphier-pxs2-pinctrl" - for PXs2 SoC >>> + "socionext,uniphier-ld6b-pinctrl" - for LD6b SoC >>> + "socionext,uniphier-ld11-pinctrl" - for LD11 SoC >>> + "socionext,uniphier-ld20-pinctrl" - for LD20 SoC >>> + "socionext,uniphier-pxs3-pinctrl" - for PXs3 SoC >>> + >>> +Note: >>> +The UniPhier pinctrl should be a subnode of a "syscon" compatible node. >>> + >>> +Example: >>> + soc-glue@5f800000 { >>> + compatible = "socionext,uniphier-pro4-soc-glue", >>> + "simple-mfd", "syscon"; >>> + reg = <0x5f800000 0x2000>; >>> + >>> + pinctrl: pinctrl { >>> + compatible = "socionext,uniphier-pro4-pinctrl"; >> >> There's not a contiguous register range that can be put here? > > > Right. > > I saw SATA PHY registers are inserted among the pinctrl registers. Okay, Acked-by: Rob Herring <robh@xxxxxxxxxx> > Hardware engineers often make crazy design. If there's 2 ways to do things, they will find a 3rd way. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html