>From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx] >Sent: Donnerstag, 30. November 2017 15:00 >On Thu, Nov 30, 2017 at 2:36 PM, Patrick Brünn <P.Bruenn@xxxxxxxxxxxx> >wrote: > >Thomas: >I tend to prefer as Linus pointed the // style throughout when there >is only a license and copyright involved. Here this would mean: > >> +// SPDX-License-Identifier: GPL-2.0 >> +// Copyright (c) 2004-2011 Freescale Semiconductor, Inc. All Rights >Reserved. > >What's you take since you wrote the doc for this? And is there still >some updates needed for this since your last patch set? > While looking closer into different files I think it would become multiline again: +// SPDX-License-Identifier: GPL-2.0 +/* + * Real Time Clock (RTC) Driver for i.MX53 + * Copyright (c) 2004-2011 Freescale Semiconductor, Inc. + * Copyright (c) 2017 Beckhoff Automation GmbH & Co. KG + */ > >Patrick: >Side note a trailing "All Rights Reserved." in a copyright statement >is never needed, even though customarily cargo culted by everyone, >including me. >Started in 1910, it become fully obsolete in 2000 thanks to Nicaragua >[1] signing the Berne convention. > >[1] https://en.wikipedia.org/wiki/All_rights_reserved Interessting. I just kept it because it was in the original file from freescale. But with this background, I think it's fine to drop it, now. Thanks, Patrick Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
