On Mon, Nov 27, 2017 at 06:15:25PM -0200, Fabio Estevam wrote: > On Mon, Nov 27, 2017 at 2:52 PM, Russell King > <rmk+kernel@xxxxxxxxxxxxxxx> wrote: > > > - }; > > + reg_usbh1_vbus: usb-h1-vbus { > > + compatible = "regulator-fixed"; > > + enable-active-high; > > + gpio = <&gpio1 0 0>; > > gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>; would be easier to read. > > > + reg_usbotg_vbus: usb-otg-vbus { > > + compatible = "regulator-fixed"; > > + enable-active-high; > > + gpio = <&gpio3 22 0>; > > Ditto. > > > + reg_brcm: brcm-reg { > > + compatible = "regulator-fixed"; > > + enable-active-high; > > + gpio = <&gpio3 19 0>; > > Ditto. Again, this is not new code, such a change should be a separate patch, maybe even separate from this series. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html