Hi Wolfgang! > On 26.11.2017, at 20:05, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> wrote: >> Test messages sent and received: 32 >> (I can not go to longer tests because I may hit a bug I am just >> now trying to fix in the current code level). > > This test does not load the bus a lot but uses burst of message to trigger out-of-order issues. Please run the test without "-v" and much longer. I agree, but as mentioned: I am debugging something else, which makes the system slightly unstable, so I refrained from running longer tests... >> If you are interested in any more specific tests that I should >> be running, then please list those and I can report them >> when submitting V2 of the patch set. > > Other useful test are about bus error reporting and error state changes. > > Can bus errors been disabled via interrupt? I do not see that CAN_CTRLMODE_BERR_REPORTING is handled. This means that bus error reporting is always on which may put heavy load on the system. e.g if no cable is connected and a message sent (at 1MB/s). > > Concerning the error state changes, have a look to [1]. Yes - it comes with the 9 (32-bit) register read on every interrupt. This is actually an optimization to avoid kernel latencies that would occur when reading 3 sets of registers separately. Also longer reads means a higher likleyhood that DMA will be used by the spi-controller/driver. > >> Just to put everything into perspective: >> The equipment available to me is: >> * beagle bone black with c_can >> * raspberry pi 3 with mcp2515 >> * raspberry pi CM3 with mcp2517fd >> * raspberry pi 2 with mcp2517fd >> * saleae logic analyzer > > [1] https://marc.info/?l=linux-can&m=151147114323582&w=2 > I will try to run those and add them to the cover page for V2. > The driver has more than 3000 lines... a review will take some time. Please look mostly at the device-tree and the main comments about the rationale and performance optimizations at first. Feedback on these I could include with V2 of the patch that will fix also the above mentioned errors and MAB avoidance code. I should be able to post it later this week. Thanks, Martin-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
