On Fri, Nov 24, 2017 at 05:50:42PM +0100, Rafael J. Wysocki wrote: > On Fri, Nov 24, 2017 at 4:53 PM, Manikanta Maddireddy > <mmaddireddy@xxxxxxxxxx> wrote: > > In 'commit 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS")' > > PM QoS resume latency modified 0 as "no latency at all". However > > dev_pm_qos_raw_read_value() returns 0 for devices which doesn't have > > PM QoS constraints. This is blocking runtime suspend for these devices > > in rpm_check_suspend_allowed(). Return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT > > when PM QoS constraints are not available for a particular device. > > > > Fixes: 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS") > > That commit has been reverted, so this patch is not applicable and > therefore the whole series isn't. > > What kernel is it based off? It looks like this might have crept in via commit 0759e80b84e3 ("PM / QoS: Fix device resume latency framework"). But checking more closely, that commit actually incorporates this change already. According to the git log the correct commit for this showed up in linux-next only today, which is probably why Manikanta missed it. Manikanta: can you try rebasing your series on top of next-20171124? git should notice that this particular change is already part of that and drop it during the rebase. Thierry
Attachment:
signature.asc
Description: PGP signature