RE: [PATCH v2 1/4] Documentation : can : flexcan : Add big-endian property to device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




HI Marc,

> -----Original Message-----
> From: Marc Kleine-Budde [mailto:mkl@xxxxxxxxxxxxxx]
> Sent: Thursday, November 23, 2017 3:32 PM
> To: Pankaj Bansal <pankaj.bansal@xxxxxxx>; wg@xxxxxxxxxxxxxx; linux-
> can@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Cc: Varun Sethi <V.Sethi@xxxxxxx>; Poonam Aggrwal
> <poonam.aggrwal@xxxxxxx>
> Subject: Re: [PATCH v2 1/4] Documentation : can : flexcan : Add big-endian
> property to device tree
> 
> On 11/23/2017 10:55 AM, Pankaj Bansal wrote:
> > The FlexCAN controller can be modelled as little or big endian
> > depending on SOC design. This device tree property identifies the
> > controller endianness and the driver reads/writes controller registers
> > based on that.
> >
> > This is optional property. i.e. if this property is not present in
> > device tree node then controller is assumed to be little endian. if
> > this property is present then controller is assumed to be big endian.
> >
> > Signed-off-by: Pankaj Bansal <pankaj.bansal@xxxxxxx>
> > Reviewed-by: Poonam Aggrwal <poonam.aggrwal@xxxxxxx>
> 
> Please document the default behaviour in the bindings if the big-endian
> property is missing.

Ok.

> 
> This and the other series have to be applied in the correct order, otherwise
> you break bisectability when removing the "fsl,p1010-flexcan"
> from the mx{25,35,53} devicetree before adding the compatible to the driver.
> Maybe merge these two series?
> 

Can we merge these 2 series ? one set of changes are in net/can directory which is managed in can-next branch.
Other set of changes are in device tree which is managed in dt-next branch.
I thought both these branches are independently updated and then all these branches
are merged in linux-next.
Please correct me if I am wrong.

> Marc
> 
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux