On Sun, Nov 19, 2017 at 6:09 PM, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Nov 17, 2017 at 08:45:11AM -0600, Rob Herring wrote: >> Add more string property checks for label, bootargs, and stdout-path. > > Where does 'label' appear? I'm not immediately recalling it as a > property with global meaning. It's documented in DT spec/ePAPR. It can be anywhere. It's the property for the human readable identifiers such as the label on ethernet ports, serial ports, LEDs, etc. > bootargs and stdout-path are from /chosen of course. I have some > mixed feelings about whether it's reasonable to check it's a string > everywhere, rather than specifically just in /chosen. We don't really want to see the same property names with different meanings. I think checking the location is a separate check. You've generally suggested splitting up tests rather than have all in one tests. Not sure if we should check known properties only appear in chosen or that chosen only has known properties (assuming we can enumerate that list. Maybe we allow things like "linux,*"). Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
