On 11/10, Randy Dunlap wrote: > On 11/10/2017 05:45 PM, Stephen Boyd wrote: > > It isn't clear if this function of_node_put()s the 'from' > > argument, or the node it finds in the search. Clearly indicate > > which variable is touched. > > > > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> > > --- > > drivers/of/base.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/of/base.c b/drivers/of/base.c > > index 63897531cd75..602c5d65734a 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);> * @from: The node to start searching from or NULL, the node > > * @from: The node to start searching from or %NULL; the node > > > * you pass will not be searched, only the next one > > * will; typically, you pass what the previous call > > * will. Typically, you pass what the previous call > Rob, do you want me to fold this in? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html