Hi Rob On Fri, 2017-11-10 at 15:26 -0600, Rob Herring wrote: > On Tue, Nov 07, 2017 at 04:36:22PM +0100, Christoph Fritz wrote: > > +Optional properties: > > + > > + - isil,external-resistor: integer in kOhm of external resistor R_ext. > > + Valid values are from 1 to 1000. > > + If not supplied, 100 kOhm will be assumed. > > Add an unit suffix as defined in property-units.txt. Thanks, I'll use "isil,external-resistor-ohms" as defined in property-units.txt. What bothers me a bit is that there is no "-kilo-ohms" suffix but a "-micro-ohms" which is pretty uncommon. Even the only use of suffix "-micro-ohms" could have been expressed easily as "-ohms" while being more readable: qcom,external-resistor-micro-ohms = <10000>; Due to stable dt-api I suppose this cannot be changed and/or extended with "-kilo-ohms", right? Thanks -- Christoph -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
