On 11/08/2017 03:36 PM, Mark Brown wrote: > On Wed, Nov 08, 2017 at 03:25:04PM -0600, Andrew F. Davis wrote: > >> - ret = of_get_named_gpio(np, "gpio-reset", 0); >> + ret = of_get_named_gpio(np, "reset-gpio", 0); > > This is obviously an incompatible change in the binding which will break > any production DTs relying on the current behaviour. You need to keep > support for the existing property. > I understand the reasons not to change driver behavior wrt DT, but this driver did not make functional use of this gpio, only going forward will this gpio be used for actually reseting the device (in some patches I will post soon). So I would like to fix this incorrect binding *before* fixing it will cause behavior incompatibilities. > It also doesn't look like a good fix if we're aiming for conformance > with DT naming conventions as unless things changed all GPIO related > properties are supposed to end -gpios even if they can only ever specify > a single GPIO. > If that is the new standard I can fix this patch to use -gpios. I know we cant change all messed up DT bindings, but I hope an exception can be make in this case for sanity sake. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
