On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe
> <clabbe.montjoie@xxxxxxxxx> wrote:
> > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
>
> The subject should say "add .... device node", not driver.
>
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
> > ---
> > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > index 19acae1b4089..68e5135410ec 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > @@ -336,6 +336,14 @@
> > #interrupt-cells = <3>;
> > #gpio-cells = <3>;
> >
> > + emac_rgmii_pins: emac-rgmii-pins {
> > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> > + "PD11", "PD12", "PD13", "PD14", "PD18",
> > + "PD19", "PD21", "PD22", "PD23";
> > + function = "gmac";
> > + drive-strength = <40>;
> > + };
> > +
>
> You should mention this change in your commit log.
And add a comment about why that drive strength is needed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
