Hi Arnd, Arnd Bergmann <arnd@xxxxxxxx> writes: > Commit a67e9472da42 ("of: Add array read functions with min/max size > limits") added a new interface for reading variable-length arrays from > DT properties. One user was added in dsa recently and this causes a > build error because that code can be built with CONFIG_OF disabled: > > net/dsa/dsa2.c: In function 'dsa_switch_parse_member_of': > net/dsa/dsa2.c:678:7: error: implicit declaration of function 'of_property_read_variable_u32_array'; did you mean 'of_property_read_u32_array'? [-Werror=implicit-function-declaration] > > This adds a dummy functions for of_property_read_variable_u32_array() > and a few others that had been missing here. I decided to move > of_property_read_string() and of_property_read_string_helper() in the > process to make it easier to compare the two sets of function prototypes > to make sure they match. > > Fixes: 975e6e32215e ("net: dsa: rework switch parsing") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> I missed the missing stub for of_property_read_variable_u32_array with !CONFIG_OF. Thank you for the quick fix! Reviewed-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html