On 11/02, Viresh Kumar wrote: > On 01-11-17, 14:43, Stephen Boyd wrote: > > On 11/01, Rob Herring wrote: > > > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > > > On 31 October 2017 at 16:02, Rob Herring <robh+dt@xxxxxxxxxx> wrote: > > > >> Why not a new property for magic values? opp-magic? Don't we want to > > > >> know when we have magic values? > > > > > > > > I have kept a separate property since beginning (domain-performance-state) > > > > and moved to using these magic values in the existing field because of the > > > > suggestion Kevin gave earlier. > > > > > > > > https://marc.info/?l=linux-kernel&m=149306082218001&w=2 > > > > > > > > I am not sure what to do now :) > > > > > > Okay, I guess reusing the properties is fine. > > > > > > > We call them corners on qcom platforms. Any reason we can't keep > > using that name? I'd rather not have to keep telling people that > > these fake values in some misnamed property is actually a corner. > > Surely not "corners", as these are platform and OS independent > bindings we are talking about here. Even the kernel code shouldn't > generally do that. Though your platform specific genpd driver can :) > Sorry I'm not following. We're going to need to have platform specific code that understands platform specific bindings that aren't shoved into the generic OPP bindings. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html