On Tue, Oct 31, 2017 at 11:32:57AM +0100, Jules Maselbas wrote: > Documentation modification, now interrupt-parent is an optional > property. Also fix few typos. > > Signed-off-by: Jules Maselbas <jules.maselbas@xxxxxxxxxxxxxxxx> > Reported-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/usb/maxim,max3421.txt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/maxim,max3421.txt b/Documentation/devicetree/bindings/usb/maxim,max3421.txt > index 7536c3ab3e5a..8cdbe0c85188 100644 > --- a/Documentation/devicetree/bindings/usb/maxim,max3421.txt > +++ b/Documentation/devicetree/bindings/usb/maxim,max3421.txt > @@ -1,17 +1,19 @@ > Maxim Integrated SPI-based USB 2.0 host controller MAX3421E > > Required properties: > - - compatible: "maxim,max3421" > + - compatible: Should be "maxim,max3421" > - spi-max-frequency: maximum frequency for this device must not exceed 26 MHz. > - reg: chip select number to which this device is connected. > - maxim,vbus-en-pin: <GPOUTx ACTIVE_LEVEL> > GPOUTx is the number (1-8) of the GPOUT pin of MAX3421E to drive Vbus. > ACTIVE_LEVEL is 0 or 1. > - - interrupt-parent: the phandle of the associated interrupt controller. > - - interrupts: the interuption line description for the interrupt controller. > + - interrupts: the interrupt line description for the interrupt controller. > The driver configures MAX3421E for active low level triggered interrupts, > configure your interrupt line accordingly. > > +Optional property: > + - interrupt-parent: the phandle to the associated interrupt controller. > + This all seems a bit pointless to me. interrupt-parent is required, but it can be in this node or a parent node (or not at all if a parent is the interrupt-controller). If I have to set guidance, I'd say don't document interrupt-parent at all in device bindings. BTW, if you have this wrong, dtc checks this now. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
