Re: [PATCH] ARM: keystone: dts: disable "msmcsram" clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Ok. I will delete node for this clock from DT and send v1

On 01/30/2014 03:25 PM, Shilimkar, Santosh wrote:
Disable is not good idea since it conveys wrong info....

Hyperlink case was different.

Sent from my Android phone using TouchDown (www.nitrodesk.com)

-----Original Message-----
*From:* Khoronzhuk, Ivan [ivan.khoronzhuk@xxxxxx]
*Received:* Thursday, 30 Jan 2014, 6:45am
*To:* robh+dt@xxxxxxxxxx [robh+dt@xxxxxxxxxx]; galak@xxxxxxxxxxxxxx
[galak@xxxxxxxxxxxxxx]
*CC:* pawel.moll@xxxxxxx [pawel.moll@xxxxxxx]; mark.rutland@xxxxxxx
[mark.rutland@xxxxxxx]; ijc+devicetree@xxxxxxxxxxxxxx
[ijc+devicetree@xxxxxxxxxxxxxx]; linux@xxxxxxxxxxxxxxxx
[linux@xxxxxxxxxxxxxxxx]; devicetree@xxxxxxxxxxxxxxx
[devicetree@xxxxxxxxxxxxxxx]; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
[linux-arm-kernel@xxxxxxxxxxxxxxxxxxx]; linux-kernel@xxxxxxxxxxxxxxx
[linux-kernel@xxxxxxxxxxxxxxx]; Shilimkar, Santosh [santosh.shilimkar@xxxxxx];
Khoronzhuk, Ivan [ivan.khoronzhuk@xxxxxx]
*Subject:* [PATCH] ARM: keystone: dts: disable "msmcsram" clock

At late init all unused clocks are disabled. So clocks that were not
get before will be gated. In Keysone 2 SoC we have at least one
necessary clock that is not used by any driver - "msmcsram". This
clock is necessary, because it supplies the Multicore Shared Memory
Controller (MSMC). The MSMC provides memory protection for accesses to
the MSMC SRAM and DDR3 memory from system masters. It also manages
traffic among mastering peripherals and the EMIF.

This means that MSMC clock is always needed by SoC and cannot be gated.
It is only one from necessary clocks that was not used by any driver.
So to avoid its gating at late init we have to disable it in DT.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxx>
---
   arch/arm/boot/dts/keystone-clocks.dtsi | 1 +
   1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/keystone-clocks.dtsi
b/arch/arm/boot/dts/keystone-clocks.dtsi
index 2363593..e7aea2e 100644
--- a/arch/arm/boot/dts/keystone-clocks.dtsi
+++ b/arch/arm/boot/dts/keystone-clocks.dtsi
@@ -332,6 +332,7 @@ clocks {
                   compatible = "ti,keystone,psc-clock";
                   clocks = <&chipclk1>;
                   clock-output-names = "msmcsram";
+               status = "disabled";
                   reg = <0x02350038 0xb00>, <0x0235001c 0x400>;
                   reg-names = "control", "domain";
                   domain-id = <7>;
--
1.8.3.2


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux