On Thu, Oct 26, 2017 at 5:28 PM, Bernd Edlinger
<bernd.edlinger@xxxxxxxxxx> wrote:
> This is an internal 32-bit input and 32-bit output port to the FPGA logic.
>
> Instantiate this in the device tree as:
>
> gpio3: gpio@ff706010 {
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "altr,fpgamgr-gpio";
> reg = <0xff706010 0x8>;
> status = "okay";
>
> portd: gpio-controller@0 {
> compatible = "altr,fpgamgr-gpio-output";
> gpio-controller;
> #gpio-cells = <2>;
> reg = <0>;
> };
>
> porte: gpio-controller@1 {
> compatible = "altr,fpgamgr-gpio-input";
> gpio-controller;
> #gpio-cells = <2>;
> reg = <1>;
> };
> };
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@xxxxxxxxxx>
(...)
> + err = bgpio_init(&port->bgc, gpio->dev, 4, dat, NULL, NULL,
> + NULL, NULL, pp->idx ? BGPIOF_NO_OUTPUT : 0);
Don't magically use the index to determine which block
us input-only.
Use the port-specific compatible string and match to
handle this using .data in the match.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
