On Mon, Oct 30, 2017 at 10:05:51AM +0800, Jeffy Chen wrote: > On 10/27/2017 10:38 PM, Rob Herring wrote: > >>+ prop = of_find_property(dn, "interrupt-names", NULL); > >>>+ for (name = of_prop_next_string(prop, NULL); name; > >>>+ name = of_prop_next_string(prop, name), index++) { > >>>+ if (!strcmp(name, "pci")) > >>>+ break; > >Use of_property_match_string > > > i'm trying to find the first unnamed or "pci" named irq in the > string array, so cannot use that API:) Actually, why can't you? It does exactly what your loop does right now. You'd just need to handle the -ENODATA case better. e.g., check if we have an interrupt-names property -- if not, just take index 0; if so, then use of_property_match_string(). Brian > but will change to of_property_for_each_string as Brian suggested. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html