On Thu, Aug 24, 2017 at 05:31:02PM +0800, Phil Reid wrote: > In preparation to adding of_i2c_setup_smbus_alert() move > i2c_setup_smbus_alert() to core module. of_i2c_setup_smbus_alert() > will call i2c_setup_smbus_alert() and this avoid module dependecy issues. I am not very happy with this but don't want to cause another delay. So, I hope we can discuss and fix it incrementally. From what it does, I really think both setup_alert functions belong to i2c-smbus.c. Three possibilities come to my mind (untested, though): a) use try_then_request_module somehow b) add to CONFIG_I2C something like: select I2C_SMBUS if OF c) get rid of i2c-smbus.c entirely and move it all into the core Dunno if a) or b) have been tried in the course of this series already? Kind regards, Wolfram
Attachment:
signature.asc
Description: PGP signature
