On Tue, Oct 24, 2017 at 8:23 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > Hi Jim, > > On 10/24/2017 11:15 AM, Jim Quinlan wrote: >> +#elif defined(CONFIG_MIPS) >> +int brcmstb_memory_phys_addr_to_memc(phys_addr_t pa) >> +{ >> + /* The logic here is fairly simple and hardcoded: if pa <= 0x5000_0000, >> + * then this is MEMC0, else MEMC1. >> + * >> + * For systems with 2GB on MEMC0, MEMC1 starts at 9000_0000, with 1GB >> + * on MEMC0, MEMC1 starts at 6000_0000. >> + */ >> + if (pa >= 0x50000000ULL) >> + return 1; >> + else >> + return 0; >> +} >> +#endif > > We may be missing an EXPORT_SYMBOL_GPL(brcmstb_memory_phys_to_addr_memc) > here? > > Thanks! > -- > Florian Hi Florian, I removed that EXPORT_SYMBOL_GPL() because this particular call is not directly invoked PCIe RC driver. It is indirectly invoked by brcmstb_memory_memc_size(), which is exported. Thanks, Jim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html