Hi, Felipe On 2017/10/24 16:25, Felipe Balbi wrote: > Hi, > > Yu Chen <chenyu56@xxxxxxxxxx> writes: >> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 Controller. >> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on board Hikey960. >> > >> > Signed-off-by: Yu Chen > <chenyu56@xxxxxxxxxx> > > Signed-off-by: Ning Fan <fanning4@xxxxxxxxxxxxx> > > Signed-off-by: Di Yang <yangdi10@xxxxxxxxxxxxx> > > Signed-off-by: Rui Li <lirui39@xxxxxxxxxxxxx> > I think Linaro, recently, added support for chargers to mainline. You > should use what they did. > > I'm gonna stop here. There's no way I'm going through this much code in > a single patch. Specially since 90% of it is either completely > unnecessary or should be done using already-existing generic APIs. > > Sorry, no cookie today. Thanks a lot for your comments! These codes have been tested on Hikey960 board and work well. But indeed the codes can be simplified and made comply with already-existing architecture. We will work on these codes according to your reviews and make parted patch next time. Thanks, Yu Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
