On Mon, Oct 23, 2017 at 05:32:09PM -0500, Rob Herring wrote: > On Sun, Oct 15, 2017 at 10:49:18PM +0800, Shawn Guo wrote: > > From: Pengcheng Li <lpc.li@xxxxxxxxxxxxx> > > > > It adds inno-usb2-phy driver for hi3798cv200 SoC USB 2.0 support. One > > inno-usb2-phy device can support up to two PHY ports. While there is > > device level reference clock and power reset to be controlled, each PHY > > port has its own utmi reset that needs to assert/de-assert as needed. > > > > Hi3798cv200 needs to access PHY port0 register via particular peripheral > > syscon controller register to control PHY, like turning on PHY clock. > > > > Signed-off-by: Pengcheng Li <lpc.li@xxxxxxxxxxxxx> > > Signed-off-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxxxxx> > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > --- > > .../devicetree/bindings/phy/phy-hisi-inno-usb2.txt | 31 +++ > > drivers/phy/hisilicon/Kconfig | 10 + > > drivers/phy/hisilicon/Makefile | 1 + > > drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 223 +++++++++++++++++++++ > > 4 files changed, 265 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > > create mode 100644 drivers/phy/hisilicon/phy-hisi-inno-usb2.c > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > > new file mode 100644 > > index 000000000000..4ef7af24a703 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-hisi-inno-usb2.txt > > @@ -0,0 +1,31 @@ > > +HiSilicon INNO USB2 PHY > > + > > +Required properties: > > +- compatible: Should be one of the following strings: > > + "hisilicon,inno-usb2-phy", > > + "hisilicon,hi3798cv200-usb2-phy". > > +- #phy-cells: Should be 1. The specifier is the index of the PHY port to > > + reference. > > +- hisilicon,peripheral-syscon: The phandle of syscon used to control PHY, > > + followed by a integer cell which defines the syscon register offset used > > + to talk to PHY. > > Same comments as combophy. If we agree that having the phy being child node gets us obvious benefits, I would be happy to change them all. > > +- clocks: The phandle and clock specifier pair for reference clock utmi_refclk. > > 'clk' part of the name is redundant. Are you talking about the text utmi_refclk? It's not something we put into 'clock-names' property, but just a text to tell what the clock is. Shawn > > +- resets: The list of phandle and reset specifier pairs for each reset signal > > + in reset-names. > > +- reset-names: Should contain "power_on", "utmi0" and "utmi1". The "utmi1" > > + should exist only if the device has two PHY port. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
