Problem with commit to add overlay symbols to live device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Frank, Rob,

I ran some tests with kernel v4.14-rc2, where I came across an issue with your commit "of: overlay: add overlay symbols to live device tree" (d1651b03c2df75db8eda3fbcd3a07adb337ee8b0, https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/of?h=v4.14-rc5&id=d1651b03c2df75db8eda3fbcd3a07adb337ee8b0). I am not sure whether this is a problem with your change or whether I made a mistake somewhere.

Without this commit, the following device tree overlay works fine on a Raspberry Pi:

/dts-v1/;
/plugin/;

/ {
	fragment@0 {
		target-path = "/soc/spi@7e204000";
		__overlay__ {
			#address-cells = <1>;
			#size-cells = <0>;
			status = "okay";

		        spidev1: spi@1 {
				compatible = "spidev";
				reg = <1>;
				spi-max-frequency = <5000000>;
			};
		};
	};
};

But with the commit, it is rejected:

OF: overlay: no symbols in root of device tree.
OF: overlay: of_build_overlay_info() failed for tree@/
create_overlay: Failed to create overlay (err=-22)

Only if I remove the spidev1 label, it continues to work with the commit (but this is not always possible in more complex overlays).

I hope this does not make a difference, but I use the configfs interface to load the overlay, that is not part of mainline, but shipped by several distributions nonetheless (for example in the Raspberry Pi kernel, https://github.com/raspberrypi/linux/commit/cccc24635da69799335566eb464a4c9e1fb4a8ad).

Could you tell me whether this change in behavior is intentional and whether I have to fix something in my usage?

Thanks
Alexander
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux