Hi,
On 2017년 10월 19일 18:52, Raveendra Padasalagi wrote:
> Add changes to capture optional dt attribute "input-debounce"
> provided in extcon node and used the same value if provided otherwise
> default value of 20000 usecs is used for id and vbus gpios debounce time.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@xxxxxxxxxxxx>
> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
> Reviewed-by: Srinath Mannam <srinath.mannam@xxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC
> - Changed msecs_to_jiffies() to usecs_to_jiffies()
>
> Changes in v2:
> Rename gpio_debounce_timeout_ms to debounce_usecs
>
> drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
After completing the review of patch1 from DT maintainer,
I'll merge these patch sets.
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index 9c925b0..69149e2 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -28,7 +28,7 @@
> #include <linux/workqueue.h>
> #include <linux/pinctrl/consumer.h>
>
> -#define USB_GPIO_DEBOUNCE_MS 20 /* ms */
> +#define USB_GPIO_DEBOUNCE_USEC 20000 /* us */
>
> struct usb_extcon_info {
> struct device *dev;
> @@ -41,6 +41,7 @@ struct usb_extcon_info {
>
> unsigned long debounce_jiffies;
> struct delayed_work wq_detcable;
> + unsigned int debounce_usecs;
> };
>
> static const unsigned int usb_extcon_cable[] = {
> @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
> if (IS_ERR(info->vbus_gpiod))
> return PTR_ERR(info->vbus_gpiod);
>
> + ret = of_property_read_u32(np, "input-debounce",
> + &info->debounce_usecs);
> + if (ret)
> + info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC;
> +
> info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
> if (IS_ERR(info->edev)) {
> dev_err(dev, "failed to allocate extcon device\n");
> @@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev)
>
> if (info->id_gpiod)
> ret = gpiod_set_debounce(info->id_gpiod,
> - USB_GPIO_DEBOUNCE_MS * 1000);
> + info->debounce_usecs);
> if (!ret && info->vbus_gpiod)
> ret = gpiod_set_debounce(info->vbus_gpiod,
> - USB_GPIO_DEBOUNCE_MS * 1000);
> + info->debounce_usecs);
>
> if (ret < 0)
> - info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
> + info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs);
>
> INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
