On Thu, Oct 19, 2017 at 10:27:19AM +0200, Lucas Stach wrote: > Am Donnerstag, den 19.10.2017, 10:17 +0200 schrieb Thierry Reding: > > On Wed, Oct 18, 2017 at 07:22:40PM +0200, Lucas Stach wrote: > > > Only exposes a single mode and not a complete display timing, as > > > the datasheet is rather vague about the minimum/maximum values. > > > > > > > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > > > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > v2: > > > - fix display size in documentation > > > - add bus flags > > > --- > > > .../display/panel/toshiba,lt089ac29000.txt | 8 +++++++ > > > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > > > 2 files changed, 35 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt > > > > Separate patches are preferred for bindings and driver. > > This is news to me. At least in simple-panel land, I've always only > split out additions of new vendor prefixes and kept the bindings > together with the driver. > > I'll change that in the future if you prefer otherwise. I don't mind too much either way, but I've seen Rob say he prefers separate patches. I guess ultimately that makes it easier to move the DT bindings outside of the kernel tree, but maybe there are other reasons, too. Rob, care to educate us? Thierry
Attachment:
signature.asc
Description: PGP signature
