Re: [PATCH v2 6/6] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Oct 18, 2017 at 2:29 PM, Marco Franchi <marco.franchi@xxxxxxx> wrote:
> The following build warning is seen with W=1:
>
> Warning (unit_address_vs_reg): Node /soc/aips@60000000/ethernet@63fec000/ethernet-phy@0 has a unit name, but no reg property
>
> Fix this warning by removing '@' from such node.
>
> Signed-off-by: Marco Franchi <marco.franchi@xxxxxxx>
> ---
> Changes since v1:
> -rebased to imx/dt branch
>  arch/arm/boot/dts/imx53-tx53.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index 76e7186..5d93287 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -225,7 +225,7 @@
>         mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
>         status = "okay";
>
> -       phy0: ethernet-phy@0 {
> +       phy0: ethernet-phy {

Is this MDIO bus? If so, then it should have an address.

>                 interrupts-extended = <&gpio2 4 IRQ_TYPE_EDGE_FALLING>;
>                 device_type = "ethernet-phy";

BTW, this should also go away.

>         };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux