On Mon, Jan 27, 2014 at 06:17:07PM +0000, Mark Brown wrote: > On Mon, Jan 27, 2014 at 01:03:09PM +0100, Markus Pargmann wrote: > > > case SND_SOC_BIAS_STANDBY: > > + /* Switch off master clock */ > > + if (!IS_ERR(aic32x4->mclk)) > > + clk_disable_unprepare(aic32x4->mclk); > > + > > /* Switch off PLL */ > > snd_soc_update_bits(codec, AIC32X4_PLLPR, > > AIC32X4_PLLEN, 0); > > This looks like it's disabling the MCLK before disabling the PLL - if > the two are being disabled together I would expect to see the other way > around. Yes right, should be the other way round, although it doesn't make a difference. I will change it for v4. Thanks, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
