On Mon, Jan 27, 2014 at 11:45 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > 2014-01-27 Max Filippov <jcmvbkbc@xxxxxxxxx>: >> On Mon, Jan 27, 2014 at 6:10 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: >>> On Sun, Jan 26, 2014 at 9:59 PM, Max Filippov <jcmvbkbc@xxxxxxxxx> wrote: [...] >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >>>> @@ -0,0 +1,25 @@ >>>> +* OpenCores MAC 10/100 Mbps >>>> + >>>> +Required properties: >>>> +- compatible: Should be "opencores,ethoc". >>> >>> There are not different versions of IP or is the version probeable? >> >> AFAIK there's single version of this 10/100 MAC. >> It doesn't have any identification registers. > > Since this is an IP block that people can modify due to its open > source nature, it would have been good to define a revision register > or such which would allow software to gate specific code based on that > revision. Probably yes, though I haven't heard of any modified versions of this MAC out there. [...] >>>> +Examples: >>>> + >>>> + enet0: ethoc@fd030000 { >>>> + compatible = "opencores,ethoc"; >>>> + reg = <0xfd030000 0x4000 0xfd800000 0x4000>; >>>> + interrupts = <1>; >>>> + local-mac-address = [00 50 c2 13 6f 00]; >>>> + clock-frequency = <50000000>; >>>> + mii-mgmt-clock-frequency = <5000000>; > > 5Mhz management clock? Can't you make it work with the standard 2.5Mhz > management clock? Is not there a risk not to be able to "talk" to some > PHY chips out there which do not support > 2.5Mhz management clock? Yes I can, it just didn't occur to me that there is a standard 2.5MHz setting. > Since this is an ethoc specific property, should it be prefixed with "ethoc,"? Is it worth keeping this parameter at all, or just always default to 2.5MHz? -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html