On Tue, Sep 26, 2017 at 1:25 AM, Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote: > Do not strdup() console options. It seems that the only reason for > it to be strdup()-ed was a compilation warning: printk, UART and > console drivers, for some reason, expect char pointer instead of > const char pointer. So we can just pass `of_stdout_options', but > need to cast it to char pointer. A better fix would be to change > printk, console drivers and UART to accept const char `options'; > but that will take time - there are lots of drivers to update. > > The patch also fixes a possible memory leak: add_preferred_console() > can fail, but we don't kfree() options. > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> > --- > drivers/of/base.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Applied. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
