Re: [PATCH v2] dts: display5: Device tree description of LWN's DISPLAY5 board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Lukasz,

Usually the Subject should have the ARM prefix: ARM: dts: ....

On Mon, Sep 25, 2017 at 12:37 PM, Lukasz Majewski <lukma@xxxxxxx> wrote:

> +       backlight_lvds: backlight {
> +               compatible = "pwm-backlight";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_backlight>;
> +               pwms = <&pwm2 0 5000000 0>;
> +               brightness-levels = <  0   1   2   3   4   5   6   7   8   9
> +                                     10  11  12  13  14  15  16  17  18  19
> +                                     20  21  22  23  24  25  26  27  28  29
> +                                     30  31  32  33  34  35  36  37  38  39
> +                                     40  41  42  43  44  45  46  47  48  49
> +                                     50  51  52  53  54  55  56  57  58  59
> +                                     60  61  62  63  64  65  66  67  68  69
> +                                     70  71  72  73  74  75  76  77  78  79
> +                                     80  81  82  83  84  85  86  87  88  89
> +                                     90  91  92  93  94  95  96  97  98  99
> +                                    100 101 102 103 104 105 106 107 108 109
> +                                    110 111 112 113 114 115 116 117 118 119
> +                                    120 121 122 123 124 125 126 127 128 129
> +                                    130 131 132 133 134 135 136 137 138 139
> +                                    140 141 142 143 144 145 146 147 148 149
> +                                    150 151 152 153 154 155 156 157 158 159
> +                                    160 161 162 163 164 165 166 167 168 169
> +                                    170 171 172 173 174 175 176 177 178 179
> +                                    180 181 182 183 184 185 186 187 188 189
> +                                    190 191 192 193 194 195 196 197 198 199
> +                                    200 201 202 203 204 205 206 207 208 209
> +                                    210 211 212 213 214 215 216 217 218 219
> +                                    220 221 222 223 224 225 226 227 228 229
> +                                    230 231 232 233 234 235 236 237 238 239
> +                                    240 241 242 243 244 245 246 247 248 249
> +                                    250 251 252 253 254 255>;

Do you need such fine grained brightness levels? ;-)

> +&i2c1 {
> +       clock-frequency = <400000>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c1>;
> +       status = "okay";
> +
> +       codec: tfa9879@6C {
> +               #sound-dai-cells = <0>;
> +               compatible = "tfa9879";

compatible = "nxp,tfa9879" , please.


> +&iomuxc {
> +       pinctrl-names = "default";

This line can be removed.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux