Hi Leon, On Wed, Sep 27, 2017 at 11:48:21PM -0700, Leon Luo wrote: > Hi Sakari, > > Thanks for your comments. > > Regarding imx274_tp_regs[], the first value is the test pattern mode, which > will be updated according to the input value before writing the register. > So it can't be a const. In that case you'll need to explicitly write that register; this is specific to a device whereas the static variable is the same for all devices. > > I will use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to keep the > lock/unlock mutex clean. I am traveling right now, will test it and send a > new patch this weekend. Ack. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
