Hi Mark, > Minor issue, but when #address-cells == 2, some unit addresses are > split in the middle by a ',' to separate the value of each cell, e.g. > "flash@2,0". For those, is_hex will return false and we'll compare > unit-addresses as strings. > > I took a quick look over the dts in the Linux kernel tree (with `git > grep "@.\+," -- arch/*/boot/dts` and I think every instance there > would sort correctly as a string, but it would be nice to fix the > issue regardless of how large the unit-address is. > > Perhaps we could have a helper function for reading the unit-address > that would take this into account? I was already getting nervous at the complexity of the sort function, so I added the is_hex() check to ignore any complex unit addresses. A helper function to read a unit address sounds like a simple enough solution though. Anton -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
