Hi Laurent, On Tue, Sep 19, 2017 at 08:54:12PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday, 19 September 2017 18:03:48 EEST Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 05:58:32PM +0300, Sakari Ailus wrote: > > >> This skips adding the notifier to the notifier_list. Won't this result > > >> in an oops when calling list_del(¬ifier->list) in > > >> v4l2_async_notifier_unregister() ? > > > > > > Good point. I'll add initialising the list head to the register function, > > > with an appropriate comment. > > > > I'll set v4l2_dev NULL instead; no tricks with lists needed. > > Shouldn't the notifier still be added to the notifier_list ? Would there be any benefit of that? The notifier's v4l2_dev field is also used to determine whether the notifier is registered currently. If the notifier is added to the notifier list, we need to remove it in unregistration as well. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
