Hi Philipp, On Fri, Oct 4, 2013 at 10:58 PM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > On Mon, Sep 30, 2013 at 04:40:08PM +0200, Philipp Zabel wrote: >> > > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000; >> > > }; >> > > >> > > ldo8_reg: ldo8 { >> > > - regulator-min-microvolt = <1200000>; >> > > - regulator-max-microvolt = <3600000>; >> > > + regulator-min-microvolt = <2750000>; >> > > + regulator-max-microvolt = <2750000>; >> > >> > Why this change? >> >> According to the reference manual, the TVDAC supply should be 2.75 V. If >> there are no ill effects if this ldo is actually set to 3.6 V, this >> change could be dropped. > > So you either add a comment in commit log for the change or drop the > change. Do you plan to resubmit this patch? Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html