Hi Pavel,
On Mon, Sep 18, 2017 at 12:56:55PM +0200, Pavel Machek wrote:
> Hi!
>
> > Specify the exact label used if the label property is omitted in DT, as
> > well as use label in the example that conforms to LED device naming.
> >
> > @@ -69,11 +73,11 @@ Example
> > flash-max-microamp = <320000>;
> > led-max-microamp = <60000>;
> > ams,input-max-microamp = <1750000>;
> > - label = "as3645a:flash";
> > + label = "as3645a:white:flash";
> > };
> > indicator@1 {
> > reg = <0x1>;
> > led-max-microamp = <10000>;
> > - label = "as3645a:indicator";
> > + label = "as3645a:red:indicator";
> > };
> > };
>
> Ok, but userspace still has no chance to determine if this is flash
> from main camera or flash for front camera; todays smartphones have
> flashes on both cameras.
>
> So.. Can I suggset as3645a:white:main_camera_flash or main_flash or
> ....?
If there's just a single one in the device, could you use that?
Even if we name this so for N9 (and N900), the application still would only
work with the two devices.
My suggestion would be to look for a flash LED, and perhaps the maximum
current as well. That should generally work better than assumptions on the
label.
For association with a particular camera --- in the long run I'd propose to
use Media controller / property API for that in the long run. We don't have
that yet though.
Cc Jacek, too.
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
