On Thu, Jan 23, 2014 at 12:49:50AM +0100, Sebastian Hesselbarth wrote: [..] > > Notice that Ezequiel has added an IRQ handler that just calls panic, > > so a spurious interrupt call is VERY VERY BAD. > > And I understand that he now clears watchdog's register before > requesting an irq. All that is missing is bridge_irq driver clearing > CAUSE register after masking all irqs, right? > Are you sure clearing the CAUSE register after masking the IRQs will be enough? AFAICS, until now nobody unmasks the watchdog IRQ (at least the orion_wdt driver didn't request the interruption) but *still* the CAUSE register is set upon watchdog expiration. So I would guessed a masked interrupt still raises a bit in the CAUSE register. Although I'm no sure I'm making sense here or just noise... -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html