Hi Icenowy, On 14/09/2017 16:52, Icenowy Zheng wrote: > Because of the restriction of the OF thermal framework, the thermal > sensor will fail to probe if the thermal zone doesn't exist. > Oh no, that's not good. We discussed about it on IRC and I even proposed a patch for it, telling you I would post it on the mailing list soon after. Of course, I forgot and you definitely should have yelled at me for not doing it :) I won't be able to test the patch soon. I can send it to you so that you can test it and integrate it in your patch series so it won't block you. Otherwise, we'll have to wait for a week or two for me to test it. Thanks and sorry for forgetting to post the patch you need, Quentin > Add a partial thermal zone which claims the H3 THS as the thermal sensor. > > The cooling device (CPU DVFS) is still not added as it's not ready, and > the trip points are also not added yet. > > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx> > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > index 3220da3ad790..687c6457d214 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -89,6 +89,15 @@ > }; > }; > > + thermal-zones { > + cpu-thermal { > + /* milliseconds */ > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&ths>; > + }; > + }; > + > timer { > compatible = "arm,armv7-timer"; > interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html