RE: [PATCH 2/2] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Geert-san,

> From: Geert Uytterhoeven
> Sent: Wednesday, September 13, 2017 11:55 PM
> 
> Hi Shimoda-san,
> 
> On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > This patch enables EthernetAVB for R-Car D3 draak board.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> 
> > @@ -37,6 +39,14 @@
> >  };
> >
> >  &pfc {
> > +       avb0_pins: avb {
> > +               mux {
> > +                       groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
> > +                                "avb0_mii";
> > +                       function = "avb0";
> 
> This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc:
> r8a77995: Add EthernetAVB pins, groups and functions", so it may change?

Oops, I fotgot to submit v2 PFC patch yesterday...
Yes, it is changed like other gen3 SoCs. I submitted it now. 

> And we will probably have to add driver-strengths later, to avoid a
> dependency on bootloader setup?

Yes, I will do so, if needed.

> Apart from that:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thank you for your review!

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux