On Wed, Jan 22, 2014 at 07:12:38PM -0300, Ezequiel Garcia wrote: > On Wed, Jan 22, 2014 at 01:52:13PM -0700, Jason Gunthorpe wrote: > > > Clearing BRIDGE_CAUSE will only clear all currently pending upstream > > > IRQs, of course. If WDT IRQ will be re-raised right after that in > > > BRIDGE_CAUSE depends on the actual HW implementation, i.e. we do no > > > clear the causing IRQ itself but just what it raised in BRIDGE_CAUSE. > > > > Which is why it makes no sense to clear it one time at kernel start. > > > > So, it seems we need to handle irq_startup(), as you suggested. > I've just tested the attached patch, and it's working fine: the driver's > probe() fully stops the watchdog, and then request_irq() acks and > pending interrupts, through the added irq_startup(). > > How does it look? Looks sane to me. I looked some more and there are other drivers (eg irq-metag-ext) that take this same approach. Sebastian: I looked at the irq-orion driver a bit more and noticed this: ret = irq_alloc_domain_generic_chips(domain, nrirqs, 1, np->name, handle_level_irq, clr, 0, IRQ_GC_INIT_MASK_CACHE); ^^^^^^^^^^^^^^^^^^^^^ Shouldn't it be handle_edge_irq? Otherwise who is calling irq_ack? How does this work at all? :) Jason -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html