Hi Andrew, Thank your for reviewing. On Sat, 9 Sep 2017 17:55:17 +0200 <andrew@xxxxxxx> wrote: > On Sat, Sep 09, 2017 at 09:03:05AM +0530, Jassi Brar wrote: > > On 9 September 2017 at 00:21, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > >> From: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > >> > > >> Add RTL8201F phy-id and the related functions to the driver. > > >> > > >> The original patch is as follows: > > >> https://patchwork.kernel.org/patch/2538341/ > > >> > > >> Signed-off-by: Jongsung Kim <neidhard.kim@xxxxxxx> > > >> Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> > > >> --- > > >> drivers/net/phy/realtek.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > > >> 1 file changed, 45 insertions(+) > > >> > > >> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c > > >> index 9cbe645..d9974ce 100644 > > >> --- a/drivers/net/phy/realtek.c > > >> +++ b/drivers/net/phy/realtek.c > > >> @@ -29,10 +29,23 @@ > > >> #define RTL8211F_PAGE_SELECT 0x1f > > >> #define RTL8211F_TX_DELAY 0x100 > > >> > > >> +#define RTL8201F_ISR 0x1e > > >> +#define RTL8201F_PAGE_SELECT 0x1f > > > > > > We have a page select register define for the RTL8211F right above, so > > > surely we can make that a common definition? > > > > > That is just for the sake of consistency. > > I mean RTL8211 wouldn't look neat among everything else RTL8201. > > > > Also the page-select offsets just _happen_ to be same value... > > If you look at all the other supported PHYs, they all consistently use > the same page register across models. Marvell is always 22, mscc is > always 31, vitesse is always 31. > > I would say it is a safe bet that all realtek PHYs will use 0x1f for > page select. So please add a patch which renames RTL8211F_PAGE_SELECT > to RTL821x_PAGE_SELECT. > > It is best to do this now. I spent a while cleaning up the mess the > Marvell driver had got into with its page select code. Lots of > duplicate code and defines doing the same thing. > > Andrew I see. In case of renaming to RTL821x_PAGE_SELECT, I think that I'll make a patch series as realtek PHY series including this patch independent from the series of MAC driver. --- Best Regards, Kunihiko Hayashi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
