Re: [PATCH v9 17/24] ACPI: Document how to refer to LEDs from remote nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Sep 08, 2017 at 04:54:07PM +0300, Sakari Ailus wrote:
> On Fri, Sep 08, 2017 at 04:43:20PM +0300, Mika Westerberg wrote:
> > On Fri, Sep 08, 2017 at 04:18:15PM +0300, Sakari Ailus wrote:
> > > +	Device (LED)
> > > +	{
> > > +		Name ((_DSD), Package () {
> > > +			ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
> > > +			Package () {
> > > +				Package () { "led0", "LED0" },
> > > +				Package () { "led1", "LED1" },
> > > +			}
> > > +		})
> > > +		Name ((LED0), Package () {
> > > +			ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > +			Package () {
> > > +				Package () { "led", 0 },
> > > +				Package () { "flash-max-microamp", 1000000 },
> > > +				Package () { "led-max-microamp", 100000 },
> > > +				Package () { "label", "led:salama" },
> > > +			}
> > > +		})
> > > +		Name ((LED1), Package () {
> > > +			ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > +			Package () {
> > > +				Package () { "led", 1 },
> > > +				Package () { "led-max-microamp", 10000 },
> > > +				Package () { "label", "led:huomiovalo" },
> > > +			}
> > > +		})
> > > +	}
> > > +
> > > +	Device (SEN)
> > > +	{
> > > +		Name ((_DSD), Package () {
> > > +			ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > +			Package () {
> > > +				Package () {
> > > +					"flash-leds",
> > > +					Package () { \\LED, 0, \\LED, 1 },
> > > +				}
> > > +			}
> > > +		})
> > > +	}
> > 
> > You should probably try to compile these examples first ;-)
> 
> Do you think I'm missing something else than s/\\\\/^/g ? :-)

Well, you should write

	Name (_DSD, Package () {

instead of

	Name ((_DSD), Package () {

but I guess the compiler accepts the former. However, please fix it and
make sure it compiles without issues so that we get good, working
examples.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux