Hello, These three patches lay the ground work for fan control in the pmbus core and introduce a driver for the MAX31785 Intelligent Fan Controller that makes use of the new control features. Since v2[1] I've addressed Rob's comments on the bindings, integrating the thermal support and cleaning up some warts. One of the warts was regarding the maxim,tmp-fans property which was switched to use a list of fan phandles rather than indexes. A corresponding change is made in the driver. I also did a comparison with the Aspeed PWM/Tach bindings but I'm not convinced there's much to take away from it other than those bindings are somewhat broken. In v3 I've dropped patch 4 from v2, which was a bunch of work-arounds for bad behaviour I observed in testing. At this stage the bad behaviour appears to be a product of the larger hardware design, not necessarily a problem with the Maxim chip. Guenter has performed some quick testing of a cut-down v2 driver against the MAX31785 evaluation board and couldn't reproduce the results I was seeing[2][3], which increases the likelyhood that it's not the Maxim chip and the work-around patch is inappropriate. Please review! Andrew [1] https://lkml.org/lkml/2017/8/2/88 [2] https://lkml.org/lkml/2017/9/7/669 [3] https://lkml.org/lkml/2017/9/5/53 Andrew Jeffery (3): dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation hwmon: pmbus: Add fan control support pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller .../devicetree/bindings/hwmon/pmbus/max31785.txt | 158 +++++ drivers/hwmon/pmbus/Kconfig | 10 + drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/max31785.c | 673 +++++++++++++++++++++ drivers/hwmon/pmbus/pmbus.h | 29 + drivers/hwmon/pmbus/pmbus_core.c | 224 ++++++- 6 files changed, 1080 insertions(+), 15 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt create mode 100644 drivers/hwmon/pmbus/max31785.c -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
