Hi! > On Mon, Aug 28, 2017 at 01:04:51PM +0200, Pavel Machek wrote: > > On Wed 2017-08-23 11:10:59, Sakari Ailus wrote: > > > Add a LED flash class driver for the as3654a flash controller. A V4L2 flash > > > driver for it already exists (drivers/media/i2c/as3645a.c), and this driver > > > is based on that. > > > > We do not want to have two drivers for same hardware... how is that > > supposed to work? > > No, we don't. The intent is to remove the other driver later on, as it's > implemented as a V4L2 sub-device driver. It also lacks DT support. Could we perhaps remove the driver with the same patch that merges this? Having two drivers would be confusing. > > Yes, we might want to have both LED and v4l2 interface for a single > > LED, because v4l2 is just too hairy to use, but we should not > > duplicate drivers for that. > > > > We _might_ want to do some helpers; as these LED drivers are all quite > > similar, it should be possible to have "flash led driver" and just > > link it to v4l2 and LED interfaces... > > This is what the new LED (flash) class driver does. Feature-wise it's a > superset of the old one. There's a minor matter left, though, which is > querying the flash strobe status which the old driver did and the new one > does not do yet. I don't know if anyone ever even used that feature though. Yes, I don't think anyone will notice... Anyway, Acked-by: Pavel Machek <pavel@xxxxxx> Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
