Hello, On (09/06/17 14:40), Petr Mladek wrote: [..] > > I wouldn't know :) let's find that out > > > > the patch used to pass `of_stdout_options' in v1 and v2 > > https://patches.linaro.org/patch/41559/ > > > > starting from v3 options are kstrdup-ed > > https://patchwork.kernel.org/patch/5398761/ > > I was curious. The const char * was suggested by Grant Likely, > see https://lkml.kernel.org/r/CACxGe6tQ5rWzCUcS+_fFY+rjEyua2khApAoCVKpTuJAghU=N_w@xxxxxxxxxxxxxx > I guess that the reason was to make the of_find_node_by_path() > API clean. ok, thanks. > > > AFAICT, the only reason is options within the console/printk code is a > > > char * and not a const char *. I can't imagine that options need > > > modifications? > > > > as far as I can tell, ->match callback has side efects, sometimes. > > I hope that the match() callbacks does not have this kind of side > effects. I think that they initialize some stuff, assign some values. > But I hope that they do not modify given strings, like console > name or options. At leats I am unable to find any place. > But I am not 100% sure. yeah, seems like we can pass just char *options. const-ifying options (and brl options) on the printk side would probably be a better solution. need to check if we can do that, tho. that also would require touching printk API, struct console, struct console_cmdline, ->match callbacks of every console in the kernel, etc. not like a big deal, just potentially a bit of a noisy patch. Rob, Grant, will this dirty hack work for you? I can respin the patch. --- drivers/of/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 260d33c0f26c..e6839045c454 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1781,8 +1781,8 @@ bool of_console_check(struct device_node *dn, char *name, int index) { if (!dn || dn != of_stdout || console_set_on_cmdline) return false; - return !add_preferred_console(name, index, - kstrdup(of_stdout_options, GFP_KERNEL)); + + return !add_preferred_console(name, index, (char *)of_stdout_options); } EXPORT_SYMBOL_GPL(of_console_check); -- 2.14.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
