On 30/08/17 16:53, Kishon Vijay Abraham I wrote:
> On Monday 28 August 2017 02:36 PM, Adrian Hunter wrote:
>> On 21/08/17 10:41, Kishon Vijay Abraham I wrote:
>>> +
>>> +static void sdhci_omap_set_clock(struct sdhci_host *host, unsigned int clock)
>>> +{
>>> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>>> + struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>>> + unsigned long clkdiv;
>>> +
>>> + if (!clock)
>>> + return;
>>
>> Are you sure you don't want to stop the clock.
>
> There is never a case where the MMC core sends a request to stop the clock.
> Maybe this check is not required at all.
It does when voltage switching e.g. mmc_set_uhs_voltage(), but host drivers
should support the possibility anyway.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
