On Tue, Jan 21, 2014 at 1:56 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > 2014/1/20 Rob Herring <robherring2@xxxxxxxxx>: >> On Mon, Jan 20, 2014 at 3:45 PM, Sergei Shtylyov >> <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: >>> On 01/20/2014 05:06 PM, Rob Herring wrote: [snip] >>>>> +- phy-connection-type: the same as "phy-mode" property (but described in >>>>> ePAPR); >>>>> +- phy-handle: phandle, specifies a reference to a node representing a >>>>> PHY >>>>> + device (this property is described in ePAPR); >>>>> +- phy: the same as "phy-handle" property (but actually ad-hoc one). >>> >>> >>>> Mark this as deprecated in favor of phy-handle. >>> >>> >>> Here situation is more optimistic. Quite many drivers still use >>> "phy-handle", though some use even more exotic props I didn't document here. >> >> Perhaps flagging as "Not recommended for new bindings" would be nicer wording... > > Ok, so what's the deal here, can't we use phy-handle? There is > currently no infrastructure in drivers/net/ or drivers/of/ to look for > the "phy-handle" nor "phy" properties as phandles to fetch an Ethernet > PHY device tree node. If we are to provide one common place where we > want to do this, we will have to look for both properties, why can't > we mandate the use of "phy-handle" since this is the ePAPR compliant > one? My count is 3 using "phy" and 11 using "phy-handle". Even if we mandate phy-handle, we still have to support both properties to maintain compatibility with existing DTs. But nothing new should use "phy". I'm not sure that something common really helps here. Drivers using "phy" can continue to and new ones use "phy-handle". After a quick scan, there doesn't appear to be any multi-line pattern in the drivers we could factor out. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
