On Wed, Aug 30, 2017 at 10:47 PM, Andrew Lunn <andrew@xxxxxxx> wrote:
>> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)
>> +{
>> + struct phy_device *phydev = priv->ndev->phydev;
>> + u32 value = 0;
>> +
>> + value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :
>> + NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;
>> +
>> + if (phydev->speed != SPEED_1000)
>> + value |= NETSEC_MCR_PS;
>> +
>> + if ((priv->phy_interface != PHY_INTERFACE_MODE_GMII) &&
>> + (phydev->speed == SPEED_100))
>> + value |= NETSEC_GMAC_MCR_REG_FES;
>> +
>> + value |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;
>> +
>> + if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)
>> + value |= NETSEC_GMAC_MCR_REG_IBN;
>> +
>> + if (netsec_mac_write(priv, GMAC_REG_MCR, value))
>> + return -ETIMEDOUT;
>> +
>> + priv->actual_link_speed = phydev->speed;
>> + priv->actual_duplex = phydev->duplex;
>> + netif_info(priv, drv, priv->ndev, "%s: %uMbps, duplex:%d\n",
>> + __func__, phydev->speed, phydev->duplex);
>
> phy_print_status()
>
>> + mac = of_get_mac_address(pdev->dev.of_node);
>> + if (mac)
>> + ether_addr_copy(ndev->dev_addr, mac);
>> +
>> + if (!is_valid_ether_addr(ndev->dev_addr)) {
>> + eth_hw_addr_random(ndev);
>> + dev_warn(&pdev->dev, "No MAC address found, using random\n");
>> + }
>
> So the mac address is optional, unlike what the binding document says.
>
>> + priv->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
>> + if (!priv->phy_np) {
>> + netif_err(priv, probe, ndev, "missing phy in DT\n");
>
> It is the phy-handle which is missing, not the phy.
>
>> +
>> + /* MTU range */
>> + ndev->min_mtu = ETH_MIN_MTU;
>
> No need to set this, it is the default.
>
> Otherwise, this looks good, in terms of phy and mdio.
>
Will fix these.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
