RE: [PATCH 5/8] pinctrl: sh-pfc: r8a77995: Add EthernetAVB pins, groups and functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Geert-san,

Sorry, I also missed this email...

> -----Original Message-----
> From: Geert Uytterhoeven
> Sent: Wednesday, August 16, 2017 8:06 PM
> 
> Hi Shimoda-san, Kihara-san,
> 
> On Wed, Aug 9, 2017 at 2:19 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> >
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> But before I apply this, please see my question below...
> 
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
> 
> > +static const char * const avb0_groups[] = {
> > +       "avb0_td",
> > +       "avb0_rd",
> > +       "avb0_tx_ctl",
> > +       "avb0_rx_ctl",
> > +       "avb0_txc",
> > +       "avb0_rxc",
> > +       "avb0_txcrefclk",
> > +       "avb0_link",
> > +       "avb0_magic",
> > +       "avb0_phy_int",
> > +       "avb0_mdc",
> > +       "avb0_mdio",
> > +       "avb0_avtp_pps_a",
> > +       "avb0_avtp_match_a",
> > +       "avb0_avtp_capture_a",
> > +       "avb0_avtp_pps_b",
> > +       "avb0_avtp_match_b",
> > +       "avb0_avtp_capture_b",
> > +};
> 
> Is there any specific reason this uses a different split than the
> EtherAVB groups
> in pinctrl drivers for other SoCs?

I will check this tomorrow (or later...).

Best regards,
Yoshihiro Shimoda

> Note that I do understand that the different prefix ("avb0" vs. "avb")
> was used to
> match the R-Car D3 datasheet, which is thus OK.
> 
> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux