Re: [PATCH 17/17] ARM: dts: Add missing hwmod related properties for dra7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




* Nishanth Menon <nm@xxxxxx> [170828 14:53]:
> On 08/28/2017 04:37 PM, Tony Lindgren wrote:
> > * Nishanth Menon <nm@xxxxxx> [170828 14:35]:
> > > On 08/28/2017 04:19 PM, Tony Lindgren wrote:
> > > > On dra7 we're missing the smartreflex and hdq nodes with their
> > > > related "ti,hwmods" property that the SoC interconnect code needs.
> > > > 
> > > > Note that this will only show up as a bug with "doesn't have
> > > > mpu register target base" boot errors when the legacy platform
> > > > data is removed.
> > > > 
> > > > Note that the related driver also needs to be updated to probe
> > > > using device tree and get the platform data passed to it using
> > > > auxdata with arch/arm/mach-omap2/pdata-quirks.c.
> > > > 
> > > > Let's also update the related binding documentation while at it.
> > ...
> > > > @@ -1489,6 +1497,18 @@
> > > >    			};
> > > >    		};
> > > > +		smartreflex_core: smartreflex4a0dd000 {
> > > > +			compatible = "ti,dra7-smartreflex-core";
> > > > +			ti,hwmods = "smartreflex_core";
> > > > +			reg = <0x4a0dd000 0x80>;
> > > > +		};
> > > > +
> > > > +		smartreflex_mpu: smartreflex@4a0d9000 {
> > > > +			compatible = "ti,dra7-smartreflex-mpu";
> > > > +			ti,hwmods = "smartreflex_mpu";
> > > > +			reg = <0x4a0d9000 0x80>;
> > > > +		};
> > > 
> > > 
> > > Have you checked TRM for these?
> > > http://www.ti.com/lit/ug/sprui30d/sprui30d.pdf
> > > 
> > > These are disabled on the SoC and marked as reserved.
> > 
> > Then why do we still have legacy hwmod data for them?
> 
> We should probably drop them - probably legacy of autogeneration at some
> point in history.

OK thanks, will drop them and update this patch accordingly.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux