Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

[Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>]

On Wed, Aug 23, 2017 at 01:46:50PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> 写到:
> >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote:
> >> +&reg_vcc5v0 {
> >> +	gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
> >> +	enable-active-high;
> >> +};
> >
> >Same thing here, you're not using that regulator anywhere. You don't
> >even use any of the regulators in sunxi-common-regulators.
> 
> Maybe I should drop the regulator now, and re-introduce it when adding USB/SATA?

If that's what it's used for, then yes, please.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature